lw309637554 commented on a change in pull request #1756:
URL: https://github.com/apache/hudi/pull/1756#discussion_r449947922
##########
File path:
hudi-client/src/main/java/org/apache/hudi/table/action/rollback/ListingBasedRollbackHelper.java
##########
@@ -54,29 +53,28 @@
/**
* Performs Rollback of Hoodie Tables.
*/
-public class RollbackHelper implements Serializable {
+public class ListingBasedRollbackHelper implements Serializable {
- private static final Logger LOG = LogManager.getLogger(RollbackHelper.class);
+ private static final Logger LOG =
LogManager.getLogger(ListingBasedRollbackHelper.class);
private final HoodieTableMetaClient metaClient;
private final HoodieWriteConfig config;
- public RollbackHelper(HoodieTableMetaClient metaClient, HoodieWriteConfig
config) {
+ public ListingBasedRollbackHelper(HoodieTableMetaClient metaClient,
HoodieWriteConfig config) {
this.metaClient = metaClient;
this.config = config;
}
/**
* Performs all rollback actions that we have collected in parallel.
*/
- public List<HoodieRollbackStat> performRollback(JavaSparkContext jsc,
HoodieInstant instantToRollback, List<RollbackRequest> rollbackRequests) {
+ public List<HoodieRollbackStat> performRollback(JavaSparkContext jsc,
HoodieInstant instantToRollback, List<ListingBasedRollbackRequest>
rollbackRequests) {
- String basefileExtension =
metaClient.getTableConfig().getBaseFileFormat().getFileExtension();
SerializablePathFilter filter = (path) -> {
- if (path.toString().contains(basefileExtension)) {
+ if
(path.toString().endsWith(HoodieFileFormat.PARQUET.getFileExtension())) {
Review comment:
to be format from the table object will better
##########
File path: hudi-client/src/test/java/org/apache/hudi/index/TestHoodieIndex.java
##########
@@ -328,6 +330,18 @@ public void
testSimpleTagLocationAndUpdateWithRollback(IndexType indexType) thro
assert (javaRDD.filter(record -> record.getCurrentLocation() !=
null).collect().size() == 0);
}
+ @ParameterizedTest
+ @EnumSource(value = IndexType.class, names = {"BLOOM", "GLOBAL_BLOOM",
"SIMPLE", "GLOBAL_SIMPLE"})
Review comment:
ok
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
