lw309637554 commented on a change in pull request #1756:
URL: https://github.com/apache/hudi/pull/1756#discussion_r455474421
##########
File path:
hudi-client/src/main/java/org/apache/hudi/table/action/rollback/ListingBasedRollbackHelper.java
##########
@@ -182,12 +162,12 @@ private HoodieRollbackStat
mergeRollbackStat(HoodieRollbackStat stat1, HoodieRol
* Common method used for cleaning out parquet files under a partition path
during rollback of a set of commits.
*/
private Map<FileStatus, Boolean> deleteCleanedFiles(HoodieTableMetaClient
metaClient, HoodieWriteConfig config,
- Map<FileStatus, Boolean> results, String commit, String partitionPath)
throws IOException {
+ String commit, String
partitionPath) throws IOException {
+ final Map<FileStatus, Boolean> results = new HashMap<>();
LOG.info("Cleaning path " + partitionPath);
FileSystem fs = metaClient.getFs();
- String basefileExtension =
metaClient.getTableConfig().getBaseFileFormat().getFileExtension();
PathFilter filter = (path) -> {
- if (path.toString().contains(basefileExtension)) {
+ if
(path.toString().contains(HoodieFileFormat.PARQUET.getFileExtension())) {
Review comment:
Get it. it is because master merge do not handle well. Let me fix it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
