the-other-tim-brown commented on code in PR #9511:
URL: https://github.com/apache/hudi/pull/9511#discussion_r1303570089
##########
hudi-common/src/main/java/org/apache/hudi/common/table/view/FileSystemViewManager.java:
##########
@@ -220,16 +220,15 @@ public static FileSystemViewManager
createViewManager(final HoodieEngineContext
final
HoodieMetadataConfig metadataConfig,
final
FileSystemViewStorageConfig config,
final
HoodieCommonConfig commonConfig) {
- return createViewManager(context, metadataConfig, config, commonConfig,
(SerializableSupplier<HoodieTableMetadata>) null);
+ return createViewManager(context, metadataConfig, config, commonConfig,
null);
}
- public static FileSystemViewManager createViewManager(final
HoodieEngineContext context,
- final
HoodieMetadataConfig metadataConfig,
- final
FileSystemViewStorageConfig config,
- final
HoodieCommonConfig commonConfig,
- final String basePath)
{
+ public static FileSystemViewManager createViewManagerWithTableMetadata(final
HoodieEngineContext context,
+ final
HoodieMetadataConfig metadataConfig,
+ final
FileSystemViewStorageConfig config,
+ final
HoodieCommonConfig commonConfig) {
return createViewManager(context, metadataConfig, config, commonConfig,
Review Comment:
I think we would need a way to get this config at runtime but I don't see a
way to do that with the current structure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
