codope commented on code in PR #9511:
URL: https://github.com/apache/hudi/pull/9511#discussion_r1304315619
##########
hudi-common/src/main/java/org/apache/hudi/common/table/view/FileSystemViewManager.java:
##########
@@ -220,16 +220,15 @@ public static FileSystemViewManager
createViewManager(final HoodieEngineContext
final
HoodieMetadataConfig metadataConfig,
final
FileSystemViewStorageConfig config,
final
HoodieCommonConfig commonConfig) {
- return createViewManager(context, metadataConfig, config, commonConfig,
(SerializableSupplier<HoodieTableMetadata>) null);
+ return createViewManager(context, metadataConfig, config, commonConfig,
null);
}
- public static FileSystemViewManager createViewManager(final
HoodieEngineContext context,
- final
HoodieMetadataConfig metadataConfig,
- final
FileSystemViewStorageConfig config,
- final
HoodieCommonConfig commonConfig,
- final String basePath)
{
+ public static FileSystemViewManager createViewManagerWithTableMetadata(final
HoodieEngineContext context,
+ final
HoodieMetadataConfig metadataConfig,
+ final
FileSystemViewStorageConfig config,
+ final
HoodieCommonConfig commonConfig) {
return createViewManager(context, metadataConfig, config, commonConfig,
Review Comment:
Typically metadata config is controlled internally. When there are metadata
configs that could differ by table, then I think it should be part of table
config (e.g. the metadata partitions that are enabled is already part of table
config). Since we have the metaClient here, we can get the tableConfig as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
