yihua commented on code in PR #9511:
URL: https://github.com/apache/hudi/pull/9511#discussion_r1304613352
##########
hudi-common/src/main/java/org/apache/hudi/common/table/view/FileSystemViewManager.java:
##########
@@ -220,16 +220,15 @@ public static FileSystemViewManager
createViewManager(final HoodieEngineContext
final
HoodieMetadataConfig metadataConfig,
final
FileSystemViewStorageConfig config,
final
HoodieCommonConfig commonConfig) {
- return createViewManager(context, metadataConfig, config, commonConfig,
(SerializableSupplier<HoodieTableMetadata>) null);
+ return createViewManager(context, metadataConfig, config, commonConfig,
null);
}
- public static FileSystemViewManager createViewManager(final
HoodieEngineContext context,
- final
HoodieMetadataConfig metadataConfig,
- final
FileSystemViewStorageConfig config,
- final
HoodieCommonConfig commonConfig,
- final String basePath)
{
+ public static FileSystemViewManager createViewManagerWithTableMetadata(final
HoodieEngineContext context,
+ final
HoodieMetadataConfig metadataConfig,
+ final
FileSystemViewStorageConfig config,
+ final
HoodieCommonConfig commonConfig) {
return createViewManager(context, metadataConfig, config, commonConfig,
Review Comment:
I'm talking about whether the file system view can just build on FS-based
table metadata even if the metadata table is enabled. I think we don't have to
differentiate this across tables for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
