danny0405 commented on code in PR #9546:
URL: https://github.com/apache/hudi/pull/9546#discussion_r1306792665
##########
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/table/HoodieSparkTable.java:
##########
@@ -91,7 +91,7 @@ protected HoodieIndex getIndex(HoodieWriteConfig config,
HoodieEngineContext con
protected Option<HoodieTableMetadataWriter> getMetadataWriter(
String triggeringInstantTimestamp,
HoodieFailedWritesCleaningPolicy failedWritesCleaningPolicy) {
- if (config.isMetadataTableEnabled() ||
metaClient.getTableConfig().isMetadataTableAvailable()) {
+ if
(!HoodieTableMetadata.isMetadataTable(metaClient.getBasePathV2().toString()) &&
config.isMetadataTableEnabled()) {
// if any partition is deleted, we need to reload the metadata table
writer so that new table configs are picked up
Review Comment:
I guess the check
`HoodieTableMetadata.isMetadataTable(metaClient.getBasePathV2().toString())` is
unnecessary because MDT already disable its MDT explicitly.
and we should also fix:
https://github.com/apache/hudi/blob/418a47e6eec8bd5cb06d17e11d28c3e90cf8455d/hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java#L175
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
