danny0405 commented on code in PR #9546:
URL: https://github.com/apache/hudi/pull/9546#discussion_r1306795342
##########
hudi-common/src/main/java/org/apache/hudi/common/table/log/InstantRange.java:
##########
@@ -153,6 +155,10 @@ public ExplicitMatchRange(Set<String> instants) {
@Override
public boolean isInRange(String instant) {
+ // if instant time is solo commit time or any special instant time that
has suffix in MDT (which will not match DT's commit times), we treat them as
valid.
+ if (instant.startsWith(SOLO_COMMIT_TIMESTAMP) || instant.length() == 20)
{
+ return true;
Review Comment:
The code is so hacky and error prone.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
