linliu-code commented on code in PR #9572:
URL: https://github.com/apache/hudi/pull/9572#discussion_r1312177580
##########
hudi-common/src/main/java/org/apache/hudi/common/model/HoodieAvroRecord.java:
##########
@@ -184,16 +185,20 @@ public HoodieRecord<T> copy() {
@Override
public HoodieRecord wrapIntoHoodieRecordPayloadWithParams(
- Schema recordSchema, Properties props,
+ Schema recordSchema,
+ Properties props,
Option<Pair<String, String>> simpleKeyGenFieldsOpt,
Boolean withOperation,
Option<String> partitionNameOp,
Boolean populateMetaFields,
Option<Schema> schemaWithoutMetaFields) throws IOException {
- IndexedRecord indexedRecord = (IndexedRecord)
data.getInsertValue(recordSchema, props).get();
+ HoodieAvroRecordMerger merger = HoodieAvroRecordMerger.INSTANCE;
Review Comment:
Hi Danny, after discussion with @yihua, I will create a separate task to
deprecate these APIs for HoodieAvroRecord class if possible for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
