voonhous opened a new pull request, #9625:
URL: https://github.com/apache/hudi/pull/9625
### Change Logs
The default values for the configs below are incorrect:
1. hoodie.datasource.write.row.writer.enable
2. hoodie.clustering.preserve.commit.metadata (getPreserveHoodieMetadata)
The default values are not loaded from `#defaultVal` as the configurations
are defined in a module-scope that is inaccessible by the current scope. This
is why config keys are defined as string here.
Raising a PR to fix these inconsistencies first. Subsequent refactoring
might be required to move these config-keys to a scope that is accessible by
all other (relevant) modules.
### Impact
None - correctness + ease of debugging through consistency
### Risk level (write none, low medium or high below)
None
### Documentation Update
_Describe any necessary documentation update if there is any new feature,
config, or user-facing change_
- _The config description must be updated if new configs are added or the
default value of the configs are changed_
- _Any new feature or user-facing change requires updating the Hudi website.
Please create a Jira ticket, attach the
ticket number here and follow the
[instruction](https://hudi.apache.org/contribute/developer-setup#website) to
make
changes to the website._
### Contributor's checklist
- [x] Read through [contributor's
guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Change Logs and Impact were stated clearly
- [ ] Adequate tests were added if applicable
- [ ] CI passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
