linliu-code commented on code in PR #9593:
URL: https://github.com/apache/hudi/pull/9593#discussion_r1316810807
##########
hudi-common/src/main/java/org/apache/hudi/common/model/HoodieAvroRecordMerger.java:
##########
@@ -43,8 +43,11 @@ public String getMergingStrategy() {
}
@Override
- public Option<Pair<HoodieRecord, Schema>> merge(HoodieRecord older, Schema
oldSchema, HoodieRecord newer, Schema newSchema, TypedProperties props) throws
IOException {
- return combineAndGetUpdateValue(older, newer, newSchema, props)
+ public Option<Pair<HoodieRecord, Schema>> merge(Option<HoodieRecord> older,
Schema oldSchema, Option<HoodieRecord> newer, Schema newSchema, TypedProperties
props) throws IOException {
+ if (!older.isPresent() || !newer.isPresent()) {
Review Comment:
@yihua, I understand that `keyToNewRecords` may contain extra records that
are for insert only. Since `writeIncomingRecords` has inserted them, why do we
need to merge logic? To support potential custom logic?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
