linliu-code commented on code in PR #9593:
URL: https://github.com/apache/hudi/pull/9593#discussion_r1317889990
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/Iterators.scala:
##########
@@ -244,19 +244,13 @@ class RecordMergingFileIterator(logFiles:
List[HoodieLogFile],
val curRow = baseFileIterator.next()
val curKey = curRow.getString(recordKeyOrdinal)
val updatedRecordOpt = removeLogRecord(curKey)
- if (updatedRecordOpt.isEmpty) {
- // No merge is required, simply load current row and project into
required schema
- nextRecord = requiredSchemaProjection(curRow)
- true
- } else {
- val mergedRecordOpt = merge(curRow, updatedRecordOpt.get)
- if (mergedRecordOpt.isEmpty) {
+ val mergedRecordOpt = merge(curRow, updatedRecordOpt)
Review Comment:
The original code did that. So I will remove my change here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
