stream2000 commented on code in PR #9558:
URL: https://github.com/apache/hudi/pull/9558#discussion_r1316898057
##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/HoodieCleaner.java:
##########
@@ -64,6 +64,13 @@ public HoodieCleaner(Config cfg, JavaSparkContext jssc) {
LOG.info("Creating Cleaner with configs : " + props.toString());
}
+ public HoodieCleaner(Config cfg, TypedProperties props, JavaSparkContext
jssc) {
+ this.cfg = cfg;
+ this.jssc = jssc;
+ this.props = props;
Review Comment:
> The existing constructor already satisfy the needs.
Yes, however if we want to reuse existing constructor, we need pass the prop
file path and the cmd line config from `HoodieMultiTableServicesMain` to
`HoodieCleaner`. And we will parse the config(read props file and use cmd line
config to override it) for every `TableServiceTask` , which is redundant.
Current implementation will do the config parsing in
`HoodieMultiTableServicesMain` only, and all the `TableServiceTask` will use
the final config parsed by `HoodieMultiTableServicesMain`. What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
