stream2000 commented on code in PR #9558:
URL: https://github.com/apache/hudi/pull/9558#discussion_r1317999559
##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/HoodieCleaner.java:
##########
@@ -64,6 +64,13 @@ public HoodieCleaner(Config cfg, JavaSparkContext jssc) {
LOG.info("Creating Cleaner with configs : " + props.toString());
}
+ public HoodieCleaner(Config cfg, TypedProperties props, JavaSparkContext
jssc) {
+ this.cfg = cfg;
+ this.jssc = jssc;
+ this.props = props;
Review Comment:
> Then we can make one constructor to invokes the other one.
Thanks for your suggestions~ I have slightly refactored the code and make it
cleaner, PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
