LXin96 commented on code in PR #9631:
URL: https://github.com/apache/hudi/pull/9631#discussion_r1318098651
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieWriteClient.java:
##########
@@ -1299,6 +1302,15 @@ public final HoodieTable initTable(WriteOperationType
operationType, Option<Stri
// Validate table properties
metaClient.validateTableProperties(config.getProps());
+ initTimer(operationType, table);
+
Review Comment:
thx for your reply. in fact, the method initTable I didn't do any change,
just extract the part for named init timer method.I actually want to use the
init timer method to init the writeTimer used in
org.apache.hudi.client.BaseHoodieWriteClient#emitCommitMetrics, when i want to
emitCommitMetrics, the writeTimer object have to be not null , or the method
emitCommitMetrics will be jumpped over。when i print log ,I find the writeTimer
in method [org.apache.hudi.client.BaseHoodieWriteClient#emitCommitMetrics] is
null,
so i put the initTimer method after the [HoodieTable table =
createTable(config, hadoopConf);]
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieWriteClient.java:
##########
@@ -1299,6 +1302,15 @@ public final HoodieTable initTable(WriteOperationType
operationType, Option<Stri
// Validate table properties
metaClient.validateTableProperties(config.getProps());
+ initTimer(operationType, table);
+
Review Comment:
thx for your reply. in fact, the method initTable I didn't do any change,
just extract the part for named init timer method.I actually want to use the
init timer method to init the writeTimer used in
org.apache.hudi.client.BaseHoodieWriteClient#emitCommitMetrics, when i want to
emitCommitMetrics, the writeTimer object have to be not null , or the method
emitCommitMetrics will be jumpped over。when i print log ,I find the writeTimer
in method [org.apache.hudi.client.BaseHoodieWriteClient#emitCommitMetrics] is
null,
so i put the initTimer method after the [HoodieTable table =
createTable(config, hadoopConf);]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
