LXin96 commented on code in PR #9631:
URL: https://github.com/apache/hudi/pull/9631#discussion_r1318181968
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieWriteClient.java:
##########
@@ -1299,6 +1302,15 @@ public final HoodieTable initTable(WriteOperationType
operationType, Option<Stri
// Validate table properties
metaClient.validateTableProperties(config.getProps());
+ initTimer(operationType, table);
+
Review Comment:
bulk_writer‘s metric is ok, and we can get metric and report. when flink
checkpoint try to commit, it will call the
org.apache.hudi.client.BaseHoodieWriteClient#commitStats to report other
metrics, however the writeTimer in BaseHoodieWriteClient is null, when call
the method org.apache.hudi.client.BaseHoodieWriteClient#emitCommitMetrics.
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieWriteClient.java:
##########
@@ -1299,6 +1302,15 @@ public final HoodieTable initTable(WriteOperationType
operationType, Option<Stri
// Validate table properties
metaClient.validateTableProperties(config.getProps());
+ initTimer(operationType, table);
+
Review Comment:
bulk_writer‘s metric is ok, and we can get metric and report. when flink
checkpoint try to commit, it will call the
org.apache.hudi.client.BaseHoodieWriteClient#commitStats to report other
metrics, however the writeTimer in BaseHoodieWriteClient is null, when call
the method org.apache.hudi.client.BaseHoodieWriteClient#emitCommitMetrics.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
