yihua commented on code in PR #9473:
URL: https://github.com/apache/hudi/pull/9473#discussion_r1320360360
##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/sources/helpers/IncrSourceHelper.java:
##########
@@ -130,7 +130,7 @@ public static QueryInfo generateQueryInfo(JavaSparkContext
jssc, String srcBaseP
}
});
- String previousInstantTime = beginInstantTime;
+ String previousInstantTime = DEFAULT_BEGIN_TIMESTAMP;
Review Comment:
I think there's still a hole here. If `beginInstantTime` is the first
commit in the active timeline and there are archived commits,
`previousInstantTime` should not be set to `DEFAULT_BEGIN_TIMESTAMP`? Could
you check this case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
