codope commented on code in PR #9590:
URL: https://github.com/apache/hudi/pull/9590#discussion_r1321298553
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java:
##########
@@ -1243,7 +1250,11 @@ public String getPreCombineField() {
}
public String getWritePayloadClass() {
- return getString(WRITE_PAYLOAD_CLASS_NAME);
+ RecordPayloadType payloadType =
RecordPayloadType.valueOf(getString(WRITE_PAYLOAD_TYPE));
+ if (payloadType.equals(RecordPayloadType.CUSTOM)) {
+ return getString(WRITE_PAYLOAD_CLASS_NAME);
Review Comment:
Actually, this method is not used. I am going to remove it. However, to your
point about inference, we do that in `HoodieTableConfig` or `HoodieWriterUtils`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
