codope commented on code in PR #9590:
URL: https://github.com/apache/hudi/pull/9590#discussion_r1321301288
##########
hudi-common/src/main/java/org/apache/hudi/common/table/HoodieTableConfig.java:
##########
@@ -697,7 +738,13 @@ public HoodieCDCSupplementalLoggingMode
cdcSupplementalLoggingMode() {
}
public String getKeyGeneratorClassName() {
- return getString(KEY_GENERATOR_CLASS_NAME);
+ String keyGeneratorClassName = null;
+ if (contains(KEY_GENERATOR_TYPE)) {
+ keyGeneratorClassName =
KeyGeneratorType.valueOf(getString(KEY_GENERATOR_TYPE)).getClassName();
+ } else if (contains(KEY_GENERATOR_CLASS_NAME)) {
+ keyGeneratorClassName = getString(KEY_GENERATOR_CLASS_NAME);
+ }
Review Comment:
please check my comment about not keeping this logic in enum at
https://github.com/apache/hudi/pull/9590/files#r1321299763
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
