codope commented on code in PR #9579:
URL: https://github.com/apache/hudi/pull/9579#discussion_r1321647254
##########
hudi-common/src/test/java/org/apache/hudi/common/table/view/TestHoodieTableFileSystemView.java:
##########
@@ -1432,7 +1439,12 @@ public void testReplaceWithTimeTravel() throws
IOException {
CommitUtils.buildMetadata(Collections.emptyList(),
partitionToReplaceFileIds, Option.empty(), WriteOperationType.INSERT_OVERWRITE,
"", HoodieTimeline.REPLACE_COMMIT_ACTION);
commitTimeline = metaClient.getActiveTimeline();
HoodieInstant instant2 = new HoodieInstant(true,
HoodieTimeline.REPLACE_COMMIT_ACTION, commitTime2);
- saveAsComplete(commitTimeline, instant2,
Option.of(commitMetadata.toJsonString().getBytes(StandardCharsets.UTF_8)));
+ saveAsComplete(
+ commitTimeline,
+ instant2,
+ commitMetadata instanceof HoodieReplaceCommitMetadata
+ ?
serializeReplaceCommitMetadata(convertReplaceCommitMetadata((HoodieReplaceCommitMetadata)
commitMetadata))
+ : serializeCommitMetadata(convertCommitMetadata(commitMetadata)));
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
