codope commented on code in PR #9579:
URL: https://github.com/apache/hudi/pull/9579#discussion_r1321729701
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieWriteClient.java:
##########
@@ -283,8 +287,11 @@ protected void commit(HoodieTable table, String
commitActionType, String instant
}
// update Metadata table
writeTableMetadata(table, instantTime, metadata, writeStatuses);
- activeTimeline.saveAsComplete(new HoodieInstant(true, commitActionType,
instantTime),
- Option.of(metadata.toJsonString().getBytes(StandardCharsets.UTF_8)));
+ activeTimeline.saveAsComplete(
+ new HoodieInstant(true, commitActionType, instantTime),
+ metadata instanceof HoodieReplaceCommitMetadata
+ ?
serializeReplaceCommitMetadata(convertReplaceCommitMetadata((HoodieReplaceCommitMetadata)
metadata))
+ : serializeCommitMetadata(convertCommitMetadata(metadata)));
}
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
