boneanxs commented on code in PR #9617:
URL: https://github.com/apache/hudi/pull/9617#discussion_r1322811455


##########
hudi-common/src/main/java/org/apache/hudi/metadata/HoodieTableMetadataUtil.java:
##########
@@ -955,8 +956,9 @@ public static HoodieTableFileSystemView 
getFileSystemView(HoodieTableMetaClient
     // though we may have initialized them.
     HoodieTimeline timeline = metaClient.getActiveTimeline();
     if (timeline.empty()) {
+      HoodieTimeGeneratorConfig timeGeneratorConfig = 
HoodieTimeGeneratorConfig.newBuilder().withPath(metaClient.getBasePathV2().toString()).build();
       final HoodieInstant instant = new HoodieInstant(false, 
HoodieTimeline.DELTA_COMMIT_ACTION,

Review Comment:
   This method is just an initialize step, right? If so, I think the 
instantTime generated here is just a fake time, and won't be used actually.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to