danny0405 commented on code in PR #9617:
URL: https://github.com/apache/hudi/pull/9617#discussion_r1316602612
##########
hudi-common/src/main/java/org/apache/hudi/common/table/timeline/HoodieActiveTimeline.java:
##########
@@ -795,6 +822,22 @@ protected void createFileInMetaPath(String filename,
Option<byte[]> content, boo
metaClient.getFs().createImmutableFileInPath(fullPath, content);
}
}
+
+ protected void createCompleteInstantWithCompletionTime(HoodieInstant
instant, Option<byte[]> content) {
+ try {
+ trueTimeGenerator.lock();
+ String currentTime = HoodieInstantTimeGenerator.formatDate(new
Date(trueTimeGenerator.nowAsMillis(false)));
+ HoodieInstant instantWithCompletionTime = new
HoodieInstant(instant.getState(), instant.getAction(),
Review Comment:
Can you explain why the `HoodieActiveTimeline#createNewInstantTime` can not
work correctly here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
