codope commented on code in PR #9590:
URL: https://github.com/apache/hudi/pull/9590#discussion_r1324228818
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/keygen/KeyGenUtils.java:
##########
@@ -86,11 +86,11 @@ private static KeyGeneratorType
inferKeyGeneratorTypeForAutoKeyGen(String partit
if (!StringUtils.isNullOrEmpty(partitionFields)) {
int numPartFields = partitionFields.split(",").length;
if (numPartFields == 1) {
- return KeyGeneratorType.SIMPLE;
+ return KeyGeneratorType.SIMPLE_KEYGEN;
}
- return KeyGeneratorType.COMPLEX;
+ return KeyGeneratorType.COMPLEX_KEYGEN;
Review Comment:
Yeah earlier I had kept the same. But, while fixing some tests, I realized
there is index type SIMPLE and keygen type SIMPLE and with static imports it
might not be very readable. So, I added the suffix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
