danny0405 commented on code in PR #9590:
URL: https://github.com/apache/hudi/pull/9590#discussion_r1325213089
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/keygen/KeyGenUtils.java:
##########
@@ -86,11 +86,11 @@ private static KeyGeneratorType
inferKeyGeneratorTypeForAutoKeyGen(String partit
if (!StringUtils.isNullOrEmpty(partitionFields)) {
int numPartFields = partitionFields.split(",").length;
if (numPartFields == 1) {
- return KeyGeneratorType.SIMPLE;
+ return KeyGeneratorType.SIMPLE_KEYGEN;
}
- return KeyGeneratorType.COMPLEX;
+ return KeyGeneratorType.COMPLEX_KEYGEN;
Review Comment:
> with static imports it might not be very readable.
Not very persuasive from my comprehension, just fix these two variables
should be okay if you think they are confusing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
