nsivabalan commented on code in PR #9667:
URL: https://github.com/apache/hudi/pull/9667#discussion_r1326650375
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieWriteClient.java:
##########
@@ -1363,6 +1363,10 @@ public void close() {
// before this point
this.index.close();
this.tableServiceClient.close();
+ // shutdown metrics
+ if (this.metrics != null && this.metrics.getMetrics() != null) {
Review Comment:
hey @prashantwason : can you review this. we have few tests written w/
metadata table. after this fix those tests are failing since we shutdown the
metrics, the metrics from registry are not accessible once the write operation
is complete.
Test of interest:
https://github.com/apache/hudi/blob/f72bf39e5e0f7431a8772961af988da346dfb376/hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/client/functional/TestHoodieBackedMetadata.java#L2902
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
