the-other-tim-brown commented on code in PR #9667:
URL: https://github.com/apache/hudi/pull/9667#discussion_r1327523911
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieWriteClient.java:
##########
@@ -1363,6 +1363,10 @@ public void close() {
// before this point
this.index.close();
this.tableServiceClient.close();
+ // shutdown metrics
+ if (this.metrics != null && this.metrics.getMetrics() != null) {
Review Comment:
Does this imply the metrics will not be available to scrape after the client
closes? That can be a problem if you have a longer scrape interval like 30
seconds for example
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
