danny0405 commented on code in PR #9776:
URL: https://github.com/apache/hudi/pull/9776#discussion_r1349444563
##########
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/client/TestHoodieClientMultiWriter.java:
##########
@@ -516,10 +516,13 @@ public void
testMultiWriterWithAsyncTableServicesWithConflict(HoodieTableType ta
// We want the upsert to go through only after the compaction
// and cleaning schedule completion. So, waiting on latch here.
latchCountDownAndWait(scheduleCountDownLatch, 30000);
- if (tableType == HoodieTableType.MERGE_ON_READ) {
- // Since the compaction already went in, this upsert has
+ if (tableType == HoodieTableType.MERGE_ON_READ && !(resolutionStrategy
instanceof PreferWriterConflictResolutionStrategy)) {
+ // HUDI-6897: Improve
SimpleConcurrentFileWritesConflictResolutionStrategy for NB-CC
Review Comment:
yeah, that would be a nice improvement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
