danny0405 commented on code in PR #9776:
URL: https://github.com/apache/hudi/pull/9776#discussion_r1349445871
##########
hudi-common/src/main/java/org/apache/hudi/common/table/view/AbstractTableFileSystemView.java:
##########
@@ -203,11 +221,10 @@ protected List<HoodieFileGroup>
buildFileGroups(Stream<HoodieBaseFile> baseFileS
if (baseFiles.containsKey(pair)) {
baseFiles.get(pair).forEach(group::addBaseFile);
}
- if (logFiles.containsKey(pair)) {
- logFiles.get(pair).forEach(group::addLogFile);
- }
-
if (addPendingCompactionFileSlice) {
+ // pending compaction file slice must be added before log files so that
+ // the log files completed later than the compaction instant time
could be included
+ // in the file slice with that compaction instant time as base instant
time.
Review Comment:
they are handled in the same way of master code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
