jonvex commented on code in PR #9743:
URL: https://github.com/apache/hudi/pull/9743#discussion_r1357335183
##########
hudi-common/src/main/java/org/apache/hudi/common/table/log/block/HoodieAvroDataBlock.java:
##########
@@ -153,11 +156,14 @@ protected <T> ClosableIterator<T>
deserializeRecords(HoodieReaderContext<T> read
}
private static class RecordIterator implements
ClosableIterator<IndexedRecord> {
+
+ private final Boolean whichImplementation = false;
private byte[] content;
private final SizeAwareDataInputStream dis;
private final GenericDatumReader<IndexedRecord> reader;
private final ThreadLocal<BinaryDecoder> decoderCache = new
ThreadLocal<>();
-
+ private Option<Schema> castSchema = Option.empty();
+ private UnaryOperator<Object> converter;
Review Comment:
[Avro schema type
promotion](https://avro.apache.org/docs/1.11.1/specification/) (just ctrl-f for
promotion in the link) does not accommodate promotion from number types to
string. This is a common ask so we are adding the feature.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]