jonvex commented on code in PR #9743:
URL: https://github.com/apache/hudi/pull/9743#discussion_r1357341403


##########
hudi-common/src/main/java/org/apache/hudi/common/table/log/block/HoodieAvroDataBlock.java:
##########
@@ -153,11 +156,14 @@ protected <T> ClosableIterator<T> 
deserializeRecords(HoodieReaderContext<T> read
   }
 
   private static class RecordIterator implements 
ClosableIterator<IndexedRecord> {
+
+    private final Boolean whichImplementation = false;
     private byte[] content;
     private final SizeAwareDataInputStream dis;
     private final GenericDatumReader<IndexedRecord> reader;
     private final ThreadLocal<BinaryDecoder> decoderCache = new 
ThreadLocal<>();
-
+    private Option<Schema> castSchema = Option.empty();

Review Comment:
   Renamed to `promotedSchema` and updated some other method names to make it 
clear that this is for type promotion and not schema evolution as a whole



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to