danny0405 commented on code in PR #9850:
URL: https://github.com/apache/hudi/pull/9850#discussion_r1358068254
##########
hudi-flink-datasource/hudi-flink/src/test/java/org/apache/hudi/sink/TestWriteCopyOnWrite.java:
##########
@@ -538,11 +539,20 @@ public void testWriteMultiWriterInvolved() throws
Exception {
.assertNextEvent()
.checkpointComplete(1)
.checkWrittenData(EXPECTED3, 1);
- // step to commit the 2nd txn, should throw exception
- // for concurrent modification of same fileGroups
- pipeline1.checkpoint(1)
- .assertNextEvent()
- .checkpointCompleteThrows(1, HoodieWriteConflictException.class,
"Cannot resolve conflicts");
+ // step to commit the 2nd txn
+ pipeline1 = pipeline1
+ .checkpoint(1)
+ .assertNextEvent();
+ if (OptionsResolver.isLocklessMultiWriter(conf)) {
+ // should success for concurrent modification of same fileGroups if
using lockless multi writers
Review Comment:
It should be always true? `OptionsResolver.isLocklessMultiWriter(conf)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
