danny0405 commented on code in PR #9850:
URL: https://github.com/apache/hudi/pull/9850#discussion_r1358070940
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/utils/TransactionUtils.java:
##########
@@ -67,7 +67,8 @@ public static Option<HoodieCommitMetadata>
resolveWriteConflictIfAny(
Option<HoodieInstant> lastCompletedTxnOwnerInstant,
boolean reloadActiveTimeline,
Set<String> pendingInstants) throws HoodieWriteConflictException {
- if
(config.getWriteConcurrencyMode().supportsOptimisticConcurrencyControl()) {
+ // Skip to resolve conflict if there are multiple writers working on the
same MOR table with simple bucket index
+ if
(config.getWriteConcurrencyMode().supportsOptimisticConcurrencyControl() &&
!config.isLocklessMultiWriter()) {
// deal with pendingInstants
Review Comment:
In `HoodieFlinkWriteClient.preTxn`, we can also skip the metadata collection
if the NB-CC is enabled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
