codope commented on code in PR #9879:
URL: https://github.com/apache/hudi/pull/9879#discussion_r1364294828
##########
hudi-common/src/main/java/org/apache/hudi/common/table/log/AbstractHoodieLogRecordReader.java:
##########
@@ -222,6 +222,24 @@ protected final void scanInternal(Option<KeySpec>
keySpecOpt, boolean skipProces
}
}
+ private boolean isPendingInstant(String instantTime, HoodieTimeline
completedInstantsTimeline, HoodieTimeline inflightInstantsTimeline) {
+ return
!completedInstantsTimeline.containsOrBeforeTimelineStarts(instantTime)
+ || inflightInstantsTimeline.containsInstant(instantTime);
+ }
+
+ private boolean isLogFileToRead(HoodieLogFile logFile,
Review Comment:
maybe rename to `isCommittedLogFile`
##########
hudi-common/src/main/java/org/apache/hudi/common/table/log/AbstractHoodieLogRecordReader.java:
##########
@@ -241,7 +241,12 @@ private void scanInternalV1(Option<KeySpec> keySpecOpt) {
try {
// Iterate over the paths
logFormatReaderWrapper = new HoodieLogFormatReader(fs,
- logFilePaths.stream().map(logFile -> new HoodieLogFile(new
CachingPath(logFile))).collect(Collectors.toList()),
+ logFilePaths.stream()
Review Comment:
Where are you comparing with block instant time?
If i understand correctly, `logFile.getDeltaCommitTime` will return the base
instant time for older log files, while it will return deltacommit time for
newer versions right?
If the caller of log record reader creates file slices based on completion
time and instantiates the log record reader with only committed `logFilePaths`,
then there should be no need to check here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
