danny0405 commented on code in PR #9879:
URL: https://github.com/apache/hudi/pull/9879#discussion_r1364761825
##########
hudi-common/src/main/java/org/apache/hudi/common/table/log/AbstractHoodieLogRecordReader.java:
##########
@@ -222,6 +222,24 @@ protected final void scanInternal(Option<KeySpec>
keySpecOpt, boolean skipProces
}
}
+ private boolean isPendingInstant(String instantTime, HoodieTimeline
completedInstantsTimeline, HoodieTimeline inflightInstantsTimeline) {
+ return
!completedInstantsTimeline.containsOrBeforeTimelineStarts(instantTime)
+ || inflightInstantsTimeline.containsInstant(instantTime);
+ }
+
+ private boolean isLogFileToRead(HoodieLogFile logFile,
Review Comment:
There is logic for backward compatibility, so the log file may not be
committed actually.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]