codope commented on code in PR #9871:
URL: https://github.com/apache/hudi/pull/9871#discussion_r1365448346
##########
hudi-common/src/main/java/org/apache/hudi/common/table/timeline/CompletionTimeQueryView.java:
##########
@@ -107,46 +106,13 @@ public boolean isCompletedBefore(String baseInstant,
String instantTime) {
* Returns whether the give instant time {@code instantTime} is sliced after
or on the base instant {@code baseInstant}.
*/
public boolean isSlicedAfterOrOn(String baseInstant, String instantTime) {
- Option<String> completionTimeOpt = getCompletionTime(baseInstant,
instantTime);
+ Option<String> completionTimeOpt = getCompletionTime(instantTime);
if (completionTimeOpt.isPresent()) {
return HoodieTimeline.compareTimestamps(completionTimeOpt.get(),
GREATER_THAN_OR_EQUALS, baseInstant);
}
return true;
}
- /**
- * Get completion time with a base instant time as a reference to fix the
compatibility.
- *
- * @param baseInstant The base instant
- * @param instantTime The instant time to query the completion time with
- *
- * @return Probability fixed completion time.
- */
- public Option<String> getCompletionTime(String baseInstant, String
instantTime) {
- Option<String> completionTimeOpt = getCompletionTime(instantTime);
- if (completionTimeOpt.isPresent()) {
Review Comment:
yeah, there are too many tests doing that. i've kept this condition just for
tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
