codope commented on code in PR #9871:
URL: https://github.com/apache/hudi/pull/9871#discussion_r1365814203
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java:
##########
@@ -1038,7 +1038,7 @@ protected void validateRollback(
// are completed on the dataset. Hence, this case implies a rollback of
completed commit which should actually be handled using restore.
if (compactionInstant.getAction().equals(HoodieTimeline.COMMIT_ACTION)) {
final String compactionInstantTime = compactionInstant.getTimestamp();
- if
(HoodieTimeline.LESSER_THAN_OR_EQUALS.test(commitToRollbackInstantTime,
compactionInstantTime)) {
+ if (commitToRollbackInstantTime.length() ==
compactionInstantTime.length() &&
HoodieTimeline.LESSER_THAN_OR_EQUALS.test(commitToRollbackInstantTime,
compactionInstantTime)) {
Review Comment:
now that the PR changed the MDT compaction time to a regular instant, we
have to do this for tests because in tests we have rollback instants like
"000001".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
