danny0405 commented on code in PR #9956:
URL: https://github.com/apache/hudi/pull/9956#discussion_r1377082818
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/metrics/FlinkCompactionMetrics.java:
##########
@@ -103,4 +110,16 @@ public void endCompaction() {
this.compactionCost = stopTimer(COMPACTION_KEY);
}
+ public void setCompactionFailedState(CompactionState compactionState){
+ this.compactionFailedState = compactionState.state;
+ }
+
+ public enum CompactionState{
+ SUCCESS(0),FAILED(1);
+ int state;
Review Comment:
The metric only has 0 and 1 as values, does it make sense to represent it as
a metric?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
