LXin96 commented on code in PR #9956:
URL: https://github.com/apache/hudi/pull/9956#discussion_r1377119005


##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/metrics/FlinkCompactionMetrics.java:
##########
@@ -103,4 +110,16 @@ public void endCompaction() {
     this.compactionCost = stopTimer(COMPACTION_KEY);
   }
 
+  public void setCompactionFailedState(CompactionState compactionState){
+    this.compactionFailedState = compactionState.state;
+  }
+
+  public enum CompactionState{
+     SUCCESS(0),FAILED(1);
+     int state;

Review Comment:
   en, this metric works like a state signal used to alert people to know the 
final compaction state this time. when the mor table happens many rollback, may 
user can manual operate the hudi mor table or flink job.  the pending count | 
delay cost may cant't represent the final result. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to