danny0405 commented on code in PR #10013:
URL: https://github.com/apache/hudi/pull/10013#discussion_r1387440082
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/table/catalog/HoodieCatalogUtil.java:
##########
@@ -61,9 +61,10 @@ public class HoodieCatalogUtil {
* @param hiveConfDir Hive conf directory path.
* @return A HiveConf instance.
*/
- public static HiveConf createHiveConf(@Nullable String hiveConfDir) {
+ public static HiveConf createHiveConf(@Nullable String hiveConfDir,
@Nullable org.apache.flink.configuration.Configuration flinkConf) {
Review Comment:
The method has only 1 caller, just make the param as
`org.apache.flink.configuration.Configuration` should be fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
