danny0405 commented on code in PR #10013:
URL: https://github.com/apache/hudi/pull/10013#discussion_r1392205166
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/table/catalog/HoodieCatalogUtil.java:
##########
@@ -61,9 +61,10 @@ public class HoodieCatalogUtil {
* @param hiveConfDir Hive conf directory path.
* @return A HiveConf instance.
*/
- public static HiveConf createHiveConf(@Nullable String hiveConfDir) {
+ public static HiveConf createHiveConf(@Nullable String hiveConfDir,
org.apache.flink.configuration.Configuration flinkConf) {
// create HiveConf from hadoop configuration with hadoop conf directory
configured.
- Configuration hadoopConf = HadoopConfigurations.getHadoopConf(new
org.apache.flink.configuration.Configuration());
+ final org.apache.flink.configuration.Configuration flinkConfiguration =
flinkConf == null ? new org.apache.flink.configuration.Configuration() :
flinkConf;
+ Configuration hadoopConf =
HadoopConfigurations.getHadoopConf(flinkConfiguration);
Review Comment:
Do we still need the null check?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
