nsivabalan commented on a change in pull request #1819:
URL: https://github.com/apache/hudi/pull/1819#discussion_r457472660
##########
File path:
hudi-utilities/src/main/java/org/apache/hudi/utilities/deltastreamer/DeltaSync.java
##########
@@ -337,9 +337,15 @@ private void refreshTimeline() throws IOException {
}
JavaRDD<GenericRecord> avroRDD = avroRDDOptional.get();
+ if (writeClient == null) {
+ this.schemaProvider = schemaProvider;
+ setupWriteClient();
Review comment:
all we need is a config here. don't think we need to initialize
writeClient here.
##########
File path:
hudi-common/src/main/java/org/apache/hudi/common/model/OverwriteWithLatestAvroPayload.java
##########
@@ -66,8 +74,9 @@ public OverwriteWithLatestAvroPayload
preCombine(OverwriteWithLatestAvroPayload
}
GenericRecord genericRecord = (GenericRecord) recordOption.get();
- // combining strategy here trivially ignores currentValue on disk and
writes this record
- Object deleteMarker = genericRecord.get("_hoodie_is_deleted");
+ // combining strategy here trivially ignores currentValue on disk and
writes this recordå
+ String deleteField = isDeletedField == null ? "_hoodie_is_deleted" :
isDeletedField;
Review comment:
sorry, I didn't realize the other constructor. We could then initialize
isDeletedField = "_hoodie_is_deleted"; So that one of the constructors will
over-ride the value.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
