shenh062326 commented on a change in pull request #1819:
URL: https://github.com/apache/hudi/pull/1819#discussion_r458181162
##########
File path:
hudi-common/src/main/java/org/apache/hudi/common/model/OverwriteWithLatestAvroPayload.java
##########
@@ -66,8 +74,9 @@ public OverwriteWithLatestAvroPayload
preCombine(OverwriteWithLatestAvroPayload
}
GenericRecord genericRecord = (GenericRecord) recordOption.get();
- // combining strategy here trivially ignores currentValue on disk and
writes this record
- Object deleteMarker = genericRecord.get("_hoodie_is_deleted");
+ // combining strategy here trivially ignores currentValue on disk and
writes this recordå
+ String deleteField = isDeletedField == null ? "_hoodie_is_deleted" :
isDeletedField;
Review comment:
> I don't see any tests being added as part of the patch. Would be nice
to have some tests covering the new code that was added at all levels.
>
> * WriteClient
> * Datasource if there is an existing suite of tests for other write
operations
> * Deltastreamer
Sorry for late, I will add some testcases and fix the comments.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
