hehuiyuan commented on code in PR #10209:
URL: https://github.com/apache/hudi/pull/10209#discussion_r1414953701
##########
hudi-flink-datasource/hudi-flink/src/test/java/org/apache/hudi/table/ITTestHoodieDataSource.java:
##########
@@ -1020,6 +1020,7 @@ void testStreamReadEmptyTablePath() throws Exception {
// case2: empty table without data files
Configuration conf =
TestConfigurations.getDefaultConf(tempFile.getAbsolutePath());
+ conf.setString(FlinkOptions.TABLE_TYPE, "MERGE_ON_READ");
Review Comment:
> Hmm, maybe we just fix the table type as to be in line with the
hoodie.properties when there is inconsistency instead of throwing, WDYT ?
Hi @danny0405 , It's ok.
But when inconsistency occurs, users may not be aware of them.
If you recommend this way, i will fix the table type as to be in line with
the hoodie.properties
##########
hudi-flink-datasource/hudi-flink/src/test/java/org/apache/hudi/table/ITTestHoodieDataSource.java:
##########
@@ -1020,6 +1020,7 @@ void testStreamReadEmptyTablePath() throws Exception {
// case2: empty table without data files
Configuration conf =
TestConfigurations.getDefaultConf(tempFile.getAbsolutePath());
+ conf.setString(FlinkOptions.TABLE_TYPE, "MERGE_ON_READ");
Review Comment:
It's ok.
But when inconsistency occurs, users may not be aware of them.
If you recommend this way, i will fix the table type as to be in line with
the hoodie.properties
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
