hehuiyuan commented on code in PR #10209:
URL: https://github.com/apache/hudi/pull/10209#discussion_r1419955281
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/table/HoodieTableFactory.java:
##########
@@ -100,6 +100,7 @@ public DynamicTableSink createDynamicTableSink(Context
context) {
Configuration conf =
FlinkOptions.fromMap(context.getCatalogTable().getOptions());
checkArgument(!StringUtils.isNullOrEmpty(conf.getString(FlinkOptions.PATH)),
"Option [path] should not be empty.");
+ checkTableType(conf);
setupTableOptions(conf.getString(FlinkOptions.PATH), conf);
ResolvedSchema schema = context.getCatalogTable().getResolvedSchema();
sanityCheck(conf, schema);
Review Comment:
> The sanity check already invokes `checkTableType`.
Ok , remove the test case?
https://github.com/apache/hudi/blob/d5ba82b60c77183c6abfdfb897b2d7174135d12b/hudi-flink-datasource/hudi-flink/src/test/java/org/apache/hudi/table/TestHoodieTableFactory.java#L211C55-L211C55
The FlinkOptions.TABLE_TYPE in the table options has been overwritten by
the table type value of hoodie.properties, so the HoodieValidationException
exception is not threw.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
