codope commented on code in PR #10323:
URL: https://github.com/apache/hudi/pull/10323#discussion_r1426129785
##########
hudi-common/src/main/java/org/apache/hudi/common/table/log/AbstractHoodieLogRecordReader.java:
##########
@@ -388,13 +388,13 @@ private void scanInternalV1(Option<KeySpec> keySpecOpt) {
currentInstantLogBlocks = new ArrayDeque<>();
dedupedLogBlocksInfo.getValue().forEach(block ->
currentInstantLogBlocks.push(block));
LOG.info("Merging the final data blocks");
- processQueuedBlocksForInstant(currentInstantLogBlocks,
scannedLogFiles.size(), keySpecOpt);
+ processQueuedBlocksForInstant(currentInstantLogBlocks,
scannedLogFiles.size(), keySpecOpt, logFormatReaderWrapper);
Review Comment:
I guess one way would be to port the design change of 1.0 to 0.14.1 (i.e.
remove the log file appending for multiple instants). But, I am little
skeptical of doing that in a patch release.
Or else, close the input stream immediately after scanning header and next
block offset.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
