danny0405 commented on code in PR #10323:
URL: https://github.com/apache/hudi/pull/10323#discussion_r1426161344
##########
hudi-common/src/main/java/org/apache/hudi/common/table/log/AbstractHoodieLogRecordReader.java:
##########
@@ -388,13 +388,13 @@ private void scanInternalV1(Option<KeySpec> keySpecOpt) {
currentInstantLogBlocks = new ArrayDeque<>();
dedupedLogBlocksInfo.getValue().forEach(block ->
currentInstantLogBlocks.push(block));
LOG.info("Merging the final data blocks");
- processQueuedBlocksForInstant(currentInstantLogBlocks,
scannedLogFiles.size(), keySpecOpt);
+ processQueuedBlocksForInstant(currentInstantLogBlocks,
scannedLogFiles.size(), keySpecOpt, logFormatReaderWrapper);
Review Comment:
We had an offline discussion, the input stream should be closed immediately
after the data block header is fetched, we should re-create the input stream
again with the correct offset when deserializing the records from content. That
many incrrease several rpc to data storage, but in object storage it is not a
bottleneck.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
