xuzifu666 commented on code in PR #10297:
URL: https://github.com/apache/hudi/pull/10297#discussion_r1426251104
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieCreateHandle.java:
##########
@@ -165,10 +165,7 @@ protected void doWrite(HoodieRecord record, Schema schema,
TypedProperties props
// record successful.
record.deflate();
} catch (Throwable t) {
- // Not throwing exception from here, since we don't want to fail the
entire job
- // for a single record
- writeStatus.markFailure(record, t, recordMetadata);
Review Comment:
addressed，add all Handles using markFailure and add an internal variable of
HoodieWriteHandle @boneanxs
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieCreateHandle.java:
##########
@@ -165,10 +165,7 @@ protected void doWrite(HoodieRecord record, Schema schema,
TypedProperties props
// record successful.
record.deflate();
} catch (Throwable t) {
- // Not throwing exception from here, since we don't want to fail the
entire job
- // for a single record
- writeStatus.markFailure(record, t, recordMetadata);
Review Comment:
addressed，add all Handles using markFailure and add an internal variable of
HoodieWriteHandle @boneanxs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
