danny0405 commented on code in PR #10297:
URL: https://github.com/apache/hudi/pull/10297#discussion_r1429433856
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieAppendHandle.java:
##########
@@ -294,6 +295,9 @@ private Option<HoodieRecord> prepareRecord(HoodieRecord<T>
hoodieRecord) {
hoodieRecord.deflate();
return finalRecordOpt;
} catch (Exception e) {
+ if (!ignoreWriteFailed) {
+ throw new HoodieInsertException("Error writing record " +
hoodieRecord, e);
+ }
Review Comment:
Should we fix it in the handle or when commiting the metadata ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
