danny0405 commented on code in PR #10255:
URL: https://github.com/apache/hudi/pull/10255#discussion_r1442459532
##########
hudi-flink-datasource/hudi-flink/src/test/java/org/apache/hudi/source/TestIncrementalInputSplits.java:
##########
@@ -72,67 +76,77 @@
public class TestIncrementalInputSplits extends HoodieCommonTestHarness {
@BeforeEach
- void init() throws IOException {
+ void init() {
initPath();
- initMetaClient();
}
@Test
- void testFilterInstantsWithRange() {
- HoodieActiveTimeline timeline = new HoodieActiveTimeline(metaClient, true);
+ void testFilterInstantsWithRange() throws IOException {
Configuration conf = TestConfigurations.getDefaultConf(basePath);
conf.set(FlinkOptions.READ_STREAMING_SKIP_CLUSTERING, true);
- IncrementalInputSplits iis = IncrementalInputSplits.builder()
- .conf(conf)
- .path(new Path(basePath))
- .rowType(TestConfigurations.ROW_TYPE)
-
.skipClustering(conf.getBoolean(FlinkOptions.READ_STREAMING_SKIP_CLUSTERING))
- .build();
+ conf.set(FlinkOptions.TABLE_TYPE, FlinkOptions.TABLE_TYPE_MERGE_ON_READ);
+ metaClient = HoodieTestUtils.init(basePath, HoodieTableType.MERGE_ON_READ);
+ HoodieActiveTimeline timeline = metaClient.getActiveTimeline();
HoodieInstant commit1 = new HoodieInstant(HoodieInstant.State.COMPLETED,
HoodieTimeline.DELTA_COMMIT_ACTION, "1");
HoodieInstant commit2 = new HoodieInstant(HoodieInstant.State.COMPLETED,
HoodieTimeline.DELTA_COMMIT_ACTION, "2");
HoodieInstant commit3 = new HoodieInstant(HoodieInstant.State.COMPLETED,
HoodieTimeline.DELTA_COMMIT_ACTION, "3");
timeline.createCompleteInstant(commit1);
timeline.createCompleteInstant(commit2);
timeline.createCompleteInstant(commit3);
- timeline = timeline.reload();
+ timeline = metaClient.reloadActiveTimeline();
+
+ Map<String, String> completionTimeMap =
timeline.filterCompletedInstants().getInstantsAsStream()
+ .collect(Collectors.toMap(HoodieInstant::getTimestamp,
HoodieInstant::getCompletionTime));
+ IncrementalQueryAnalyzer analyzer1 = IncrementalQueryAnalyzer.builder()
+ .metaClient(metaClient)
+ .rangeType(InstantRange.RangeType.OPEN_CLOSE)
+ .startTime(completionTimeMap.get("1"))
+ .skipClustering(true)
+ .build();
// previous read iteration read till instant time "1", next read iteration
should return ["2", "3"]
- List<HoodieInstant> instantRange2 = iis.filterInstantsWithRange(timeline,
"1");
- assertEquals(2, instantRange2.size());
- assertIterableEquals(Arrays.asList(commit2, commit3), instantRange2);
+ List<HoodieInstant> activeInstants1 =
analyzer1.analyze().getActiveInstants();
+ assertEquals(2, activeInstants1.size());
+ assertIterableEquals(Arrays.asList(commit2, commit3), activeInstants1);
// simulate first iteration cycle with read from the LATEST commit
- List<HoodieInstant> instantRange1 = iis.filterInstantsWithRange(timeline,
null);
- assertEquals(1, instantRange1.size());
- assertIterableEquals(Collections.singletonList(commit3), instantRange1);
+ IncrementalQueryAnalyzer analyzer2 = IncrementalQueryAnalyzer.builder()
+ .metaClient(metaClient)
+ .rangeType(InstantRange.RangeType.CLOSE_CLOSE)
+ .skipClustering(true)
+ .build();
+ List<HoodieInstant> activeInstants2 =
analyzer2.analyze().getActiveInstants();
+ assertEquals(1, activeInstants2.size());
+ assertIterableEquals(Collections.singletonList(commit3), activeInstants2);
// specifying a start and end commit
- conf.set(FlinkOptions.READ_START_COMMIT, "1");
- conf.set(FlinkOptions.READ_END_COMMIT, "3");
- List<HoodieInstant> instantRange3 = iis.filterInstantsWithRange(timeline,
null);
- assertEquals(3, instantRange3.size());
- assertIterableEquals(Arrays.asList(commit1, commit2, commit3),
instantRange3);
+ IncrementalQueryAnalyzer analyzer3 = IncrementalQueryAnalyzer.builder()
Review Comment:
Should already been tested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
