jonvex commented on code in PR #10467:
URL: https://github.com/apache/hudi/pull/10467#discussion_r1446548231
##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/streamer/StreamSync.java:
##########
@@ -457,7 +457,7 @@ public Pair<Option<String>, JavaRDD<WriteStatus>>
syncOnce() throws IOException
private Option<String>
getLastPendingClusteringInstant(Option<HoodieTimeline> commitTimelineOpt) {
if (commitTimelineOpt.isPresent()) {
- Option<HoodieInstant> pendingClusteringInstant =
commitTimelineOpt.get().filterPendingReplaceTimeline().lastInstant();
+ Option<HoodieInstant> pendingClusteringInstant =
commitTimelineOpt.get().getLastPendingClusterCommit();
Review Comment:
The usage in BaseHoodieTableServiceClient looks bad. I wonder if we should
think about changing the name in the timeline so we don't need to deserialize
the instants a bunch of times
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
